[Adium-devl] Yahoo! is broken

Discussion:

Peter Hosey

2008-02-19 21:49:46 UTC

1.2.2 broke Yahoo! for a lot of users on the feedback address. They
either get asked repeatedly for their password, or get told that
their username is not registered.

Suggestions on how to proceed?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adiumx.com/pipermail/devel_adium.im/attachments/20080219/5aa90b5b/attachment.bin>

Augie Fackler

2008-02-19 22:07:39 UTC

Permalink

Post by Peter Hosey
1.2.2 broke Yahoo! for a lot of users on the feedback address. They
either get asked repeatedly for their password, or get told that
their username is not registered.
Suggestions on how to proceed?

IIRC there was a commit that was stripping the part of the username
after the @ for yahoo. If that's right (can't check now), it might be
people with (say) an @sbcglobal.net email address that is also a Y!M
handle. That's something to check.

Peter Hosey

2008-02-19 22:34:15 UTC

Permalink

Post by Augie Fackler
IIRC there was a commit that was stripping the part of the username
Y!M handle. That's something to check.

This fits with what one user on feedback described: his sbcglobal.net
address was entered as such, but the error message only had the
username part of it.

As a temporary fix, I propose we only cut off after ?@yahoo.?.
Other @-suffixes would then be left alone. We can robustify this (for
hypothetical @yahoo.example.com addresses) later, in 1.3.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adiumx.com/pipermail/devel_adium.im/attachments/20080219/17d8f8ef/attachment.bin>

Augie Fackler

2008-02-19 22:39:14 UTC

Permalink

Post by Peter Hosey

Post by Augie Fackler
IIRC there was a commit that was stripping the part of the username
Y!M handle. That's something to check.

This fits with what one user on feedback described: his
sbcglobal.net address was entered as such, but the error message
only had the username part of it.
@-suffixes would then be left alone. We can robustify this (for

Peter Hosey

2008-02-19 22:54:07 UTC

Permalink

Post by Peter Hosey
@-suffixes would then be left alone. We can robustify this (for

Committed to trunk in r22649. Can you test this?

Meanwhile, I'll work on a blog post to explain the problem and that a
solution is coming soon. I think we should release a 1.2.3 for the fix.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adiumx.com/pipermail/devel_adium.im/attachments/20080219/3539a25b/attachment.bin>

Augie Fackler

2008-02-20 00:59:28 UTC

Permalink

Post by Peter Hosey

Post by Peter Hosey
@-suffixes would then be left alone. We can robustify this (for

Committed to trunk in r22649. Can you test this?
Meanwhile, I'll work on a blog post to explain the problem and that
a solution is coming soon. I think we should release a 1.2.3 for the
fix.

Confirmed to fix the issue. Merge to the branch.

Peter Hosey

2008-02-20 03:08:23 UTC

Permalink

Post by Augie Fackler
Confirmed to fix the issue. Merge to the branch.

Committed in r22650. Any objections to a 1.2.3 containing the fix?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://adiumx.com/pipermail/devel_adium.im/attachments/20080219/fbce0587/attachment.bin>

Evan Schoenberg

2008-02-20 04:23:49 UTC

Permalink

No objections except that perhaps we should look at the other
Regressions on the 1.2.3 milestone to see if there are any other
problems which can similarly be fixed in short order. For example, it
sounds like some message styles were somehow broken - David, any
thoughts? Also, is anyone else seeing the Google Talk issue for
which a ticket was filed earlier?

Cheers,
Evan

Post by Peter Hosey

Post by Augie Fackler
Confirmed to fix the issue. Merge to the branch.

Committed in r22650. Any objections to a 1.2.3 containing the fix?
_______________________________________________
Adium-devl mailing list
Adium-devl at adiumx.com
http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com

Bastian olea

2008-02-20 13:02:03 UTC

Permalink

There is a -misterious- yahoo ticket who says that some users (me
included) cant normally connect to their yahooo accounts because when
i log in i receive lots of ?authorization requested? dialogues. That
happens everytime i connect, repeating the dialogues everytime, even
showing msn contacts.

http://trac.adiumx.com/ticket/7846

Bastian Olea

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Firma.gif
Type: image/gif
Size: 5557 bytes
Desc: not available
URL: <Loading Image...

>
-------------- next part --------------

Post by Evan Schoenberg
No objections except that perhaps we should look at the other
Regressions on the 1.2.3 milestone to see if there are any other
problems which can similarly be fixed in short order. For example, it
sounds like some message styles were somehow broken - David, any
thoughts? Also, is anyone else seeing the Google Talk issue for
which a ticket was filed earlier?
Cheers,
Evan

Post by Peter Hosey

Post by Augie Fackler
Confirmed to fix the issue. Merge to the branch.

_______________________________________________
Adium-devl mailing list
Adium-devl at adiumx.com
http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com

Peter Hosey

2008-02-20 18:50:26 UTC

Permalink

Post by Bastian olea
There is a -misterious- yahoo ticket who says that some users (me
included) cant normally connect to their yahooo accounts because
when i log in i receive lots of ?authorization requested?
dialogues. That happens everytime i connect, repeating the
dialogues everytime, even showing msn contacts.
http://trac.adiumx.com/ticket/7846

Did this happen on 1.2.1, or is it new to you in 1.2.2? If it's new,
then it's a different problem from the one that ticket is talking about.

More info on the new problem:

http://www.adiumx.com/blog/2008/02/yahoo-breakage-in-122.php

Bastian olea

2008-02-20 23:02:05 UTC

Permalink

This is happening since ...(Lot of time, i dont remember, I had to
stop usaing yahoo because of this bug) Adium 1.1? I cant remember,
but this is a old bug. in the tickes there is more info aboiut this

Bastian Olea

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Firma.gif
Type: image/gif
Size: 5557 bytes
Desc: not available
URL: <Loading Image...

>
-------------- next part --------------

Post by Peter Hosey

Did this happen on 1.2.1, or is it new to you in 1.2.2? If it's
new, then it's a different problem from the one that ticket is
talking about.
http://www.adiumx.com/blog/2008/02/yahoo-breakage-in-122.php

Chris Forsythe

2008-02-21 13:35:11 UTC

Permalink

Then it's different than the topic at hand. Please keep things to 1
topic per thread discussion on this list.

Also, as this is a developer list, hopefully you were wanting to fix
the issue. :)

Chris

Post by Bastian olea
This is happening since ...(Lot of time, i dont remember, I had to
stop usaing yahoo because of this bug) Adium 1.1? I cant remember,
but this is a old bug. in the tickes there is more info aboiut this
Bastian Olea
<Firma.gif>

Post by Peter Hosey

_______________________________________________
Adium-devl mailing list
Adium-devl at adiumx.com
http://adiumx.com/mailman/listinfo/adium-devl_adiumx.com

Evan Schoenberg

2008-02-22 00:58:34 UTC

Permalink

Post by Peter Hosey
Any objections to a 1.2.3 containing the fix?

I'm fine with a 1.2.3 whenever; we clearly have a significant support
burden for the Yahoo issue at present, and numbers is just numbers.
Can someone else handle the release?

-Evan